PDavid commented on code in PR #6668:
URL: https://github.com/apache/hbase/pull/6668#discussion_r1971159565
##########
pom.xml:
##########
@@ -2749,6 +2749,81 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>unpack</id>
+ <goals>
+ <goal>unpack</goal>
+ </goals>
+ <phase>pre-site</phase>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>bootstrap</artifactId>
+ <version>2.3.2</version>
+ <type>jar</type>
+ <overWrite>true</overWrite>
+ <includes>**/css/bootstrap-responsive.min.css</includes>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>highlightjs</artifactId>
+ <version>8.7</version>
+ <type>jar</type>
+ <overWrite>true</overWrite>
+ <includes>**/styles/github.min.css,
+ **/highlight.min.js,</includes>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>font-awesome</artifactId>
+ <version>4.7.0</version>
+ <type>jar</type>
+ <overWrite>true</overWrite>
+ <includes>**/css/font-awesome.css,
+ **/fonts/fontawesome-webfont.eot,
+ **/fonts/fontawesome-webfont.svg,
+ **/fonts/fontawesome-webfont.ttf,
+ **/fonts/fontawesome-webfont.woff,
+ **/fonts/fontawesome-webfont.woff2,</includes>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>MathJax</artifactId>
+ <version>2.7.0</version>
+ <type>jar</type>
+ <overWrite>true</overWrite>
+ <includes>**/MathJax.js,
+ **/config/TeX-MML-AM_HTMLorMML.js,
+ **/jax/output/HTML-CSS/jax.js,
+ **/jax/output/HTML-CSS/imageFonts.js,
+ **/jax/output/HTML-CSS/fonts/TeX/fontdata.js,
+ **/jax/output/HTML-CSS/fonts/TeX/SansSerif/Italic/Main.js,
+
**/jax/output/HTML-CSS/fonts/TeX/SansSerif/Italic/BasicLatin.js,
+ **/extensions/MathMenu.js,
+ **/fonts/HTML-CSS/TeX/woff/MathJax_Main-Regular.woff,
+ **/fonts/HTML-CSS/TeX/woff/MathJax_Main-Italic.woff,
+ **/fonts/HTML-CSS/TeX/woff/MathJax_Math-Italic.woff,
+ **/fonts/HTML-CSS/TeX/woff/MathJax_Size1-Regular.woff,
+ **/fonts/HTML-CSS/TeX/woff/MathJax_Size3-Regular.woff,
+ **/fonts/HTML-CSS/TeX/woff/MathJax_SansSerif-Italic.woff,
+ **/fonts/HTML-CSS/TeX/otf/MathJax_Main-Regular.otf,
+ **/fonts/HTML-CSS/TeX/otf/MathJax_Main-Italic.otf,
+ **/fonts/HTML-CSS/TeX/otf/MathJax_Math-Italic.otf,
+ **/fonts/HTML-CSS/TeX/otf/MathJax_Size1-Regular.otf,
+ **/fonts/HTML-CSS/TeX/otf/MathJax_Size3-Regular.otf,
+
**/fonts/HTML-CSS/TeX/otf/MathJax_SansSerif-Italic.otf,</includes>
+ </artifactItem>
+ </artifactItems>
+ <outputDirectory>${basedir}/target/</outputDirectory>
Review Comment:
> This is same a ${project.build.directory} right?
Yes, exactly. I'll rather use `${project.build.directory}` instead.
> I hope none of this is bundled in our assembly tarballs
Thanks, that's a very good point. I'll build an assembly tarball locally and
check to make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
