NihalJain commented on code in PR #6781:
URL: https://github.com/apache/hbase/pull/6781#discussion_r1992866414
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java:
##########
@@ -701,12 +646,11 @@ public void start(CoprocessorEnvironment env) throws
IOException {
if (regionEnv instanceof HasRegionServerServices) {
RegionServerServices rsServices =
((HasRegionServerServices) regionEnv).getRegionServerServices();
- zkPermissionWatcher = rsServices.getZKPermissionWatcher();
accessChecker = rsServices.getAccessChecker();
}
}
- Preconditions.checkState(zkPermissionWatcher != null, "ZKPermissionWatcher
is null");
+ //Preconditions.checkState(zkPermissionWatcher != null,
"ZKPermissionWatcher is null");
Review Comment:
move to new class
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java:
##########
@@ -1138,8 +1082,7 @@ public Void run() throws Exception {
return null;
}
});
- zkPermissionWatcher.deleteNamespaceACLNode(namespace);
- LOG.info(namespace + " entry deleted in " +
PermissionStorage.ACL_TABLE_NAME + " table.");
+ LOG.info(namespace + " entry deleted in " +
org.apache.hadoop.hbase.security.access.PermissionStorage.ACL_TABLE_NAME + "
table.");
Review Comment:
revert or move to correct class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
