NihalJain commented on code in PR #6781:
URL: https://github.com/apache/hbase/pull/6781#discussion_r1992876878
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -8870,12 +8871,17 @@ public void requestFlush(FlushLifeCycleTracker tracker)
throws IOException {
*/
private static void decorateRegionConfiguration(Configuration conf) {
if (ReplicationUtils.isReplicationForBulkLoadDataEnabled(conf)) {
- String plugins = conf.get(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY,
"");
String replicationCoprocessorClass =
ReplicationObserver.class.getCanonicalName();
- if (!plugins.contains(replicationCoprocessorClass)) {
- conf.set(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY,
- (plugins.equals("") ? "" : (plugins + ",")) +
replicationCoprocessorClass);
- }
+ appendToRegionCoprocessorConf(conf, replicationCoprocessorClass);
+ }
+ appendToRegionCoprocessorConf(conf,
ZKAclUpdaterCoprocessor.class.getCanonicalName());
Review Comment:
nit: can we append both clsses in one call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
