ciacono commented on code in PR #6266:
URL: https://github.com/apache/hbase/pull/6266#discussion_r2004376833
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java:
##########
@@ -89,20 +89,68 @@ private RecoveredEditsWriter
getRecoveredEditsWriter(TableName tableName, byte[]
@Override
public List<Path> close() throws IOException {
- boolean isSuccessful = true;
+ boolean isSuccessful;
try {
isSuccessful = finishWriterThreads();
- } finally {
- isSuccessful &= closeWriters();
+ } catch (InterruptedIOException e) {
Review Comment:
Yes, that should be okay since in the race it would rethrow
InterruptedIOException, which would still be caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
