Apache9 commented on code in PR #6266:
URL: https://github.com/apache/hbase/pull/6266#discussion_r2012294279
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java:
##########
@@ -133,6 +127,37 @@ protected Path
closeRecoveredEditsWriter(RecoveredEditsWriter editsWriter,
return dst;
}
+ private boolean closeRecoveredEditsWriter(RecoveredEditsWriter editsWriter,
+ List<IOException> thrown) {
+ try {
+ editsWriter.writer.close();
+ } catch (IOException ioe) {
+ final String errorMsg = "Could not close recovered edits at " +
editsWriter.path;
+ LOG.error(errorMsg, ioe);
+ updateStatusWithMsg(errorMsg);
+ thrown.add(ioe);
+ return false;
+ }
+ final String msg = "Closed recovered edits writer path=" +
editsWriter.path + " (wrote "
+ + editsWriter.editsWritten + " edits, skipped " +
editsWriter.editsSkipped + " edits in "
+ + (editsWriter.nanosSpent / 1000 / 1000) + " ms)";
+ LOG.info(msg);
+ updateStatusWithMsg(msg);
+ return true;
+ }
+
+ private void removeRecoveredEditsFile(RecoveredEditsWriter editsWriter)
throws IOException {
Review Comment:
When calling from abortWriter, I do not think we should throw any exception
here? Just log the exceptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
