Apache9 commented on code in PR #6856:
URL: https://github.com/apache/hbase/pull/6856#discussion_r2012313803
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java:
##########
@@ -448,10 +497,6 @@ public static boolean isArchivedLogFile(Path p) {
* @throws IOException exception
*/
public static Path findArchivedLog(Path path, Configuration conf) throws
IOException {
- // If the path contains oldWALs keyword then exit early.
Review Comment:
What is the problem of this if condition?
I think the intention here is that, if the Path is already under the oldWALs
directory, we do not need to find it again. In your description, the path
should be under the WALs directory, not oldWALs directory? So what is the real
problem here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
