Apache9 commented on code in PR #6856:
URL: https://github.com/apache/hbase/pull/6856#discussion_r2024840571
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java:
##########
@@ -463,6 +509,12 @@ public static Path findArchivedLog(Path path,
Configuration conf) throws IOExcep
}
ServerName serverName = getServerNameFromWALDirectoryName(path);
+ if (serverName == null) {
Review Comment:
And why we need to add this logic? I think the design for this method is
that, we will only pass a WAL path which is not under the old wal directory,
but seems your fix is for passing a WAL path which is already under the old wal
directory. So under which condition we could pass a WAL path which is ready
under the old wal directory for finding the old wal file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
