stoty commented on PR #131: URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758052912
> > I am not sure about the name, but jetty12 wouldn't be great either. > > Yes hence thought to create env specific names. IUC since the eeX stuff is in separate packages, we could add any or all ee specification modules. If we keep the ee8 name, then migrate to ee9/10 for jakarta, then the module/artifact name will be misleading. I would rather add the additional eeX modules to existing jetty thirdparty tha duplicate everything for each one. As bad a jetty12 would be a bad name, at least we're not tying it to the ee spec version. Maybe jetty-new ? or Jetty-b ? > > > I guess that importing two different relocated jetty versions is not something that we want support, so re-using the package name is fine > > Yes this is a fair concern. Although, we would not want to have shaded jetty9 in our classpath if with have jetty12-eeX, but I am afraid what if hadoop timeline service or something else brings it in indirectly.? Ideally, thirdparty netty shouldn't be brought in by the hbase client. ( I have not checked if that's true) Anything expecting to run in the master/coprocessor JVMs shouldn also not be depending on thirdparty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
