Yiran-wu commented on code in PR #6856:
URL: https://github.com/apache/hbase/pull/6856#discussion_r2022347076
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java:
##########
@@ -448,10 +497,6 @@ public static boolean isArchivedLogFile(Path p) {
* @throws IOException exception
*/
public static Path findArchivedLog(Path path, Configuration conf) throws
IOException {
- // If the path contains oldWALs keyword then exit early.
Review Comment:
Thinks @Apache9 for Review.
The main reason is that when we close regionserver, WALs will be moved to
oldWALs, at the same time when enabled
“hbase.separate.oldlogdir.by.regionserver” , It is moved to the
"oldWALs/servername" directory. The RecoverdNode cannot be found it.
Closed regionserver, move wal funcation is "HRegionServer::shutdownWAL()"
The current findArchiveLog does not check for "oldWALs/servername", The WAL
file not being found.
This problem can be replicated in existing unit tests. Add
"conf.setBoolean(SEPARATE_OLDLOGDIR, true);" to the UT
"TestReplicationSource::testServerShutdownRecoveredQueue"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
