aaronbee commented on code in PR #6266:
URL: https://github.com/apache/hbase/pull/6266#discussion_r2004258613
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java:
##########
@@ -89,20 +89,68 @@ private RecoveredEditsWriter
getRecoveredEditsWriter(TableName tableName, byte[]
@Override
public List<Path> close() throws IOException {
- boolean isSuccessful = true;
+ boolean isSuccessful;
try {
isSuccessful = finishWriterThreads();
- } finally {
- isSuccessful &= closeWriters();
+ } catch (InterruptedIOException e) {
Review Comment:
Should this be `IOException` rather than `InterrptedIOException`? Since that
is what `finishWriterThreads` may throw.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java:
##########
@@ -89,20 +89,68 @@ private RecoveredEditsWriter
getRecoveredEditsWriter(TableName tableName, byte[]
@Override
public List<Path> close() throws IOException {
- boolean isSuccessful = true;
+ boolean isSuccessful;
try {
isSuccessful = finishWriterThreads();
- } finally {
- isSuccessful &= closeWriters();
+ } catch (InterruptedIOException e) {
+ // TODO if it's caught, should we log the error? If it's not rethrown?
+ abortWriters();
+ // TODO should the exception be rethrown again here to bubble up?
Review Comment:
I would suggest re-throw, since that is what the previous code was
implicitly doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
