anmolnar commented on code in PR #6931:
URL: https://github.com/apache/hbase/pull/6931#discussion_r2057219763
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -65,26 +66,25 @@
@CoreCoprocessor
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
-public class ReadOnlyController
- implements MasterCoprocessor, RegionCoprocessor, MasterObserver,
RegionObserver,
- RegionServerCoprocessor, RegionServerObserver, EndpointObserver,
BulkLoadObserver {
+public class ReadOnlyController implements MasterCoprocessor,
RegionCoprocessor, MasterObserver,
+ RegionObserver, RegionServerCoprocessor, RegionServerObserver,
EndpointObserver, BulkLoadObserver,
+ ConfigurationObserver {
private static final Logger LOG =
LoggerFactory.getLogger(ReadOnlyController.class);
- private Configuration conf;
+ private volatile boolean globalReadOnlyEnabled;
Review Comment:
Why do we need this?
Use AtomicBoolean instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
