anmolnar commented on code in PR #6931:
URL: https://github.com/apache/hbase/pull/6931#discussion_r2066856374
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -390,4 +390,12 @@ public void
preCleanupBulkLoad(ObserverContext<RegionCoprocessorEnvironment> ctx
internalReadOnlyGuard();
BulkLoadObserver.super.preCleanupBulkLoad(ctx);
}
+
+ @Override
+ public void onConfigurationChange(Configuration conf) {
+ this.globalReadOnlyEnabled =
conf.getBoolean(HConstants.HBASE_GLOBAL_READONLY_ENABLED_KEY,
+ HConstants.HBASE_GLOBAL_READONLY_ENABLED_DEFAULT);
+ LOG.info("Config {} has been dynamically changed to {}",
+ HConstants.HBASE_GLOBAL_READONLY_ENABLED_KEY,
this.globalReadOnlyEnabled);
Review Comment:
Shall we add a check whether the value has actually been changed here?
This info should only be logged if the previous value was different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
