anmolnar commented on code in PR #6931:
URL: https://github.com/apache/hbase/pull/6931#discussion_r2080511297


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -100,9 +99,6 @@ public Optional<RegionObserver> getRegionObserver() {
   @Override
   public void prePut(ObserverContext<? extends RegionCoprocessorEnvironment> 
c, Put put,
     WALEdit edit) throws IOException {
-    if (edit.isMetaEdit() || edit.isEmpty()) {
-      return;
-    }

Review Comment:
   So, you don't need these checks anymore, because you start the mini cluster 
in R/W mode in your tests. Does that mean a real cluster can be started in R/O 
mode, have you verified that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to