kgeisz commented on code in PR #6931:
URL: https://github.com/apache/hbase/pull/6931#discussion_r2103151354


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -100,9 +99,6 @@ public Optional<RegionObserver> getRegionObserver() {
   @Override
   public void prePut(ObserverContext<? extends RegionCoprocessorEnvironment> 
c, Put put,
     WALEdit edit) throws IOException {
-    if (edit.isMetaEdit() || edit.isEmpty()) {
-      return;
-    }

Review Comment:
   @anmolnar, I made it so `prePut()` and `preBatchMutate()` will skip the 
`internalReadOnlyGuard()` check if the table is a system table, rather than if 
the WALEdit is empty or a meta edit.  I also added a unit test class that 
verifies HBase can be started in Read-Only mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to