[
https://issues.apache.org/jira/browse/HBASE-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436316#comment-13436316
]
nkeywal commented on HBASE-5022:
--------------------------------
It was mainly mentioned in HBASE-4993 and HBASE-5027.
Basically, the comment in create was:
* Creates a clone of passed configuration.
* @param that Configuration to clone.
* @return a Configuration created with the hbase-*.xml files plus the given
configuration.
This comment was saying two different things (clone vs. load+merge), and I've
chosen the most efficient one (clone). As actually it was mostly used as a
clone function (while it was not a clone function) so it worked (mostly :-) ).
So imho it makes sense to revert this patch to keep the load+mergefunction, but
then we should remove the first comment: " * Creates a clone of passed
configuration.". Ideally, we should review how it's used in HBase today to
understand when they want a clone vs. when they want a load+merge... But well...
> Optimize HBaseConfiguration#create
> ----------------------------------
>
> Key: HBASE-5022
> URL: https://issues.apache.org/jira/browse/HBASE-5022
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5022.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
