[ 
https://issues.apache.org/jira/browse/HBASE-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436335#comment-13436335
 ] 

Jean-Daniel Cryans commented on HBASE-5022:
-------------------------------------------

bq. Ideally, we should review how it's used in HBase today to understand when 
they want a clone vs. when they want a load+merge... But well...

As I mentioned on dev@, at SU it's being used to add hbsae-site.xml but doing 
addHbaseResources works just as well. I would say that cloning + adding 
hbase-site.xml is also a valid use case, but the most important thing to me is 
that this is a *public* *API* so just looking at how HBase is using it is not 
enough, and you can't really ask all the users either. That's why I'm in favor 
of using the old behavior or deleting the method entirely so that instead of 
creating weird bugs for users it will just stop compiling. Obviously the former 
is less agressive.
                
> Optimize HBaseConfiguration#create
> ----------------------------------
>
>                 Key: HBASE-5022
>                 URL: https://issues.apache.org/jira/browse/HBASE-5022
>             Project: HBase
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 0.94.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 5022.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to