sanjeet006py commented on code in PR #6868:
URL: https://github.com/apache/hbase/pull/6868#discussion_r2093254382
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractClientScanner.java:
##########
@@ -34,6 +35,9 @@ protected void initScanMetrics(Scan scan) {
// check if application wants to collect scan metrics
if (scan.isScanMetricsEnabled()) {
scanMetrics = new ScanMetrics();
+ if (scan.isScanMetricsByRegionEnabled()) {
+ isScanMetricsByRegionEnabled = true;
+ }
}
Review Comment:
Yeah, I also thought the same but I also didn't have any strong opinion so,
kept it this way as was wondering what to do or should I handle the case when
`isScanMetricsEnabled()` is `false` and `isScanMetricsByRegionEnabled()` is
true given I will be setting scanMetricsEnabled if scanMetricsByRegion are
enabled. So, kept it simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
