sanjeet006py commented on code in PR #6868:
URL: https://github.com/apache/hbase/pull/6868#discussion_r2096312416
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/metrics/ScanMetrics.java:
##########
@@ -51,53 +51,118 @@ public class ScanMetrics extends ServerSideScanMetrics {
/**
* number of RPC calls
*/
- public final AtomicLong countOfRPCcalls =
createCounter(RPC_CALLS_METRIC_NAME);
+ @SuppressWarnings("checkstyle:VisibilityModifier")
Review Comment:
> You can either live with that, suffer the possibility of inaccurate metric
results, or you need to come up with a different approach.
Actually, to get accurate metrics results with this new feature the
recommendation is for users to use `getMetricsMapByRegion` to get region level
scan metrics and `getMetricsMap` to get combined overall scan metrics. I also
have a test for this scenario.
We can express this expectation via documentation. Please let me know your
thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
