vinayakphegde commented on PR #7106:
URL: https://github.com/apache/hbase/pull/7106#issuecomment-2980511787
> LGTM overall. I just have a couple of minor comments.
>
> Also, just curious - What happens when a WAL that has bogus/garbage values
is read? Is an exception thrown? This patch adds the ability to skip the empty
WALs, so it made me wonder what happens with bad/corrupted WALs.
Yes, We'll get below exception
`java.lang.Exception:
org.apache.hadoop.hbase.regionserver.wal.WALHeaderEOFException: EOF while
reading PB WAL magic
at
org.apache.hadoop.mapred.LocalJobRunner$Job.runTasks(LocalJobRunner.java:492)
~[hadoop-mapreduce-client-common-3.4.1.jar:?]
at
org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:552)
~[hadoop-mapreduce-client-common-3.4.1.jar:?]
Caused by: org.apache.hadoop.hbase.regionserver.wal.WALHeaderEOFException:
EOF while reading PB WAL magic
at
org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufWALReader.readHeader(AbstractProtobufWALReader.java:221)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufWALReader.init(AbstractProtobufWALReader.java:147)
~[classes/:?]
at
org.apache.hadoop.hbase.wal.WALFactory.createStreamReader(WALFactory.java:417)
~[classes/:?]
at
org.apache.hadoop.hbase.wal.WALFactory.createStreamReader(WALFactory.java:538)
~[classes/:?]
at
org.apache.hadoop.hbase.mapreduce.WALInputFormat$WALRecordReader.openReader(WALInputFormat.java:162)
~[classes/:?]
at
org.apache.hadoop.hbase.mapreduce.WALInputFormat$WALRecordReader.openReader(WALInputFormat.java:204)
~[classes/:?]
at
org.apache.hadoop.hbase.mapreduce.WALInputFormat$WALRecordReader.initialize(WALInputFormat.java:197)
~[classes/:?]
at
org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:561)
~[hadoop-mapreduce-client-core-3.4.1.jar:?]
at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:799)
~[hadoop-mapreduce-client-core-3.4.1.jar:?]
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:348)
~[hadoop-mapreduce-client-core-3.4.1.jar:?]
at
org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:271)
~[hadoop-mapreduce-client-common-3.4.1.jar:?]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
~[?:?]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.io.EOFException
at java.io.DataInputStream.readFully(DataInputStream.java:203) ~[?:?]
at java.io.DataInputStream.readFully(DataInputStream.java:172) ~[?:?]
at`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
