taklwu commented on code in PR #7106:
URL: https://github.com/apache/hbase/pull/7106#discussion_r2162839134
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java:
##########
@@ -846,6 +847,7 @@ private Tool initializeWalPlayer(long startTime, long
endTime) {
Configuration conf = HBaseConfiguration.create(conn.getConfiguration());
conf.setLong(WALInputFormat.START_TIME_KEY, startTime);
conf.setLong(WALInputFormat.END_TIME_KEY, endTime);
+ conf.setBoolean(IGNORE_EMPTY_FILES, true);
Review Comment:
so, this flag basically is only used for Continuous Backup? and should it be
false other than the use case of Continuous Backup ?
nit: maybe add a javadoc comment in the code that at what situation we
should and we should not use this flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
