vinayakphegde commented on code in PR #7106:
URL: https://github.com/apache/hbase/pull/7106#discussion_r2164347527
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java:
##########
@@ -846,6 +847,7 @@ private Tool initializeWalPlayer(long startTime, long
endTime) {
Configuration conf = HBaseConfiguration.create(conn.getConfiguration());
conf.setLong(WALInputFormat.START_TIME_KEY, startTime);
conf.setLong(WALInputFormat.END_TIME_KEY, endTime);
+ conf.setBoolean(IGNORE_EMPTY_FILES, true);
Review Comment:
Yeah, the default behavior is false, so I didn’t want to change it as it
might be assumed in other parts of the code.
> nit: maybe add a Javadoc comment explaining in what situations we should
or shouldn't use this flag.
Sure — this flag controls whether the WALPlayer job should throw an
exception when it encounters an empty file that it can't parse as a valid WAL
file, or whether it should skip it silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
