sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185142986
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##########
@@ -1754,6 +1758,9 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream is, long offset,
headerBuf = HEAP.allocate(hdrSize);
readAtOffset(is, headerBuf, hdrSize, false, offset, pread);
headerBuf.rewind();
+ if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.addBytesReadFromFs(hdrSize);
+ }
Review Comment:
Yeah, I also thought so but then I noticed (also mentioned in comment) that
this will typically be called when we open a HFile fresh for first time and
starting to read it from its load-on-open data section as at that time we
specify on disk size as -1. So, I don't expect this to happen in a user
triggered read path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
