wchevreuil commented on code in PR #7192:
URL: https://github.com/apache/hbase/pull/7192#discussion_r2300472107
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1378,7 +1379,8 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
}
BlockType.BlockCategory category =
hfileBlock.getBlockType().getCategory();
final boolean cacheCompressed =
cacheConf.shouldCacheCompressed(category);
- final boolean cacheOnRead = cacheConf.shouldCacheBlockOnRead(category);
+ final boolean cacheOnRead =
Review Comment:
>in other words, is these two APIs of
cacheConf.shouldCacheBlockOnRead(category) and
cacheConf.shouldCacheBlockOnRead(category, getHFileInfo(), conf) the same?
Those are not the same. The former just checks for the block type, whilst
the latter performs additional checks to figure if the data block is already
cached, in order to avoid redundant caching from file system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
