taklwu commented on code in PR #7192:
URL: https://github.com/apache/hbase/pull/7192#discussion_r2301812207
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1378,7 +1379,8 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
}
BlockType.BlockCategory category =
hfileBlock.getBlockType().getCategory();
final boolean cacheCompressed =
cacheConf.shouldCacheCompressed(category);
- final boolean cacheOnRead = cacheConf.shouldCacheBlockOnRead(category);
+ final boolean cacheOnRead =
Review Comment:
yeah, sorry I didn't explain my comment with links,
about the `cacheOnRead` , in the old PR #5905 , `cacheOnRead` has been used
within the if block `if (cacheOnly && cacheCompressed && cacheOnRead) {`
https://github.com/apache/hbase/pull/5905/files#diff-c910a49e7d962e49b199d22f38e1cd78d867351208b86bffdd56ffb9aa1aa596R1358
, but in this PR, we don't see those usage of `cacheOnRead`, did I miss
anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
