PDavid commented on code in PR #7355:
URL: https://github.com/apache/hbase/pull/7355#discussion_r2401066659
##########
pom.xml:
##########
@@ -2851,6 +2836,34 @@
<outputDirectory>${project.build.directory}</outputDirectory>
</configuration>
</execution>
+ <execution>
+ <!-- Required for the site to use local resources (e.g. not from
CDN). -->
+ <id>unpack-site-resources</id>
+ <goals>
+ <goal>unpack</goal>
+ </goals>
+ <phase>pre-site</phase>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>io.github.devacfr.maven.skins</groupId>
+ <artifactId>reflow-default-webdeps</artifactId>
Review Comment:
Yeah, I just checked, unfortunately the skin jar does not include these
static resources:
```
$ cd ~/.m2/repository/io/github/devacfr/maven/skins/reflow-maven-skin/2.3.3
$ unzip -l reflow-maven-skin-2.3.3.jar
Archive: reflow-maven-skin-2.3.3.jar
Length Date Time Name
--------- ---------- ----- ----
0 02-21-2023 16:45 META-INF/
82 02-21-2023 16:45 META-INF/MANIFEST.MF
0 02-21-2023 16:45 META-INF/maven/
0 02-21-2023 16:45 META-INF/maven/components/
0 02-21-2023 16:45 css/
0 02-21-2023 16:45 images/
0 02-21-2023 16:45 js/
0 02-21-2023 16:45 META-INF/maven/io.github.devacfr.maven.skins/
0 02-21-2023 16:45
META-INF/maven/io.github.devacfr.maven.skins/reflow-maven-skin/
762 02-21-2023 16:45 META-INF/maven/body-body.vm
1406 02-21-2023 16:45 META-INF/maven/body-default.vm
943 02-21-2023 16:45 META-INF/maven/body-doc.vm
2247 02-21-2023 16:45 META-INF/maven/components/breadcrumb.vm
2773 02-21-2023 16:45 META-INF/maven/components/carousel.vm
1192 02-21-2023 16:45 META-INF/maven/components/columns.vm
4206 02-21-2023 16:45 META-INF/maven/components/header.vm
5161 02-21-2023 16:45 META-INF/maven/components/layout.vm
2588 02-21-2023 16:45 META-INF/maven/components/nav-side-menu.vm
4273 02-21-2023 16:45 META-INF/maven/components/navbar.vm
748 02-21-2023 16:45 META-INF/maven/components/scroll-top.vm
967 02-21-2023 16:45 META-INF/maven/components/sidebar.vm
2055 02-21-2023 16:45 META-INF/maven/components/thumbnails.vm
2264 02-21-2023 16:45 META-INF/maven/components/toc-sidebar.vm
6475 02-21-2023 16:45 META-INF/maven/components/toc-topbar.vm
6751 02-21-2023 16:45 META-INF/maven/footer-default.vm
1055 02-21-2023 16:45 META-INF/maven/frame-default.vm
11328 02-21-2023 16:45 META-INF/maven/page-default.vm
8042 02-21-2023 16:45 META-INF/maven/site-macros.vm
1273 02-21-2023 16:45 META-INF/maven/site.vm
1132 02-21-2023 16:45 META-INF/maven/skin.xml
2608 02-21-2023 16:45 css/lightbox.css
1656 02-21-2023 16:45 css/print.css
14755 02-21-2023 16:45 css/reflow-skin.css
280 02-21-2023 16:45 images/close.png
8476 02-21-2023 16:45 images/loading.gif
1350 02-21-2023 16:45 images/next.png
1360 02-21-2023 16:45 images/prev.png
9418 02-21-2023 16:45 js/lightbox.min.js
11328 02-21-2023 16:45 js/reflow-skin.js
2532 02-21-2023 16:45
META-INF/maven/io.github.devacfr.maven.skins/reflow-maven-skin/pom.xml
81 02-21-2023 16:45
META-INF/maven/io.github.devacfr.maven.skins/reflow-maven-skin/pom.properties
--------- -------
121567 41 files
```
So we have to provide them separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
