ndimiduk commented on code in PR #7355:
URL: https://github.com/apache/hbase/pull/7355#discussion_r2401911198
##########
src/site/xdoc/metrics.xml:
##########
@@ -24,6 +24,7 @@ under the License.
<title>
Apache HBase (TM) Metrics
</title>
+ <link rel="shortcut icon" href="/images/favicon.ico" />
Review Comment:
Is there a way to put this in a common header so it's managed in one place?
##########
src/site/xdoc/index.xml:
##########
@@ -71,6 +74,9 @@ under the License.
<dd><p>See the <a href="book.html#security">Security</a> chapter in
the <a href="book.html#faq">Apache HBase<sup>®</sup> Reference Guide</a>, and
the general <a href="https://apache.org/security/";>Apache Security
information</a>!</p></dd>
</dl>
</section>
+ <section name="Source code">
+ <p>You can contribute on <a class="externalLink"
href="https://github.com/apache/hbase";>GitHub</a>. See the <a
href="scm.html">Source Repository page</a> for more details.</p>
+ </section>
Review Comment:
I don't think we need the ribbon. We're not in the business of promoting
github. Contributors find where to engage in the community section.
##########
src/site/site.xml:
##########
@@ -21,74 +21,49 @@
<project xmlns="http://maven.apache.org/DECORATION/1.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/DECORATION/1.0.0
http://maven.apache.org/xsd/decoration-1.0.0.xsd";>
+ xsi:schemaLocation="http://maven.apache.org/DECORATION/1.0.0
http://maven.apache.org/xsd/decoration-1.0.0.xsd";
+ name="Apache HBase">
+ <publishDate position="none"/>
+ <version position="none"/>
+
<skin>
- <!-- We tried to get some changes to the fluido-skin committed upstream
- but with little success. This is a custom artifact that contains
- some commits over the official maven-fluido-skin 1.4 release. The
- actual code is available at:
- https://github.com/joshelser/maven-fluido-skin/tree/1.4-HBase-patched.
- The hope is that we can get these fixes included upstream and
- remove the need for this custom fork. This is published to
- my end-user's GAV for ease of releasing this to maven central
- until the upstream update happens and is released.
- See HBASE-14785 and HBASE-21005 for more info. -->
- <groupId>org.apache.maven.skins</groupId>
- <artifactId>maven-fluido-skin</artifactId>
- <version>1.12.0</version>
+ <groupId>io.github.devacfr.maven.skins</groupId>
+ <artifactId>reflow-maven-skin</artifactId>
+ <version>${reflow-maven-skin.version}</version>
</skin>
+
<custom>
- <fluidoSkin>
- <topBarEnabled>true</topBarEnabled>
- <sideBarEnabled>false</sideBarEnabled>
- <googleSearch>
- <!-- The ID of the Google custom search engine to use.
- This one searches hbase.apache.org,
issues.apache.org/browse/HBASE-*,
- and user and dev mailing list archives. -->
- <customSearch>000385458301414556862:sq1bb0xugjg</customSearch>
- </googleSearch>
Review Comment:
Huh, I didn't know that it had the behavior described in the comment.
Is it this? https://programmablesearchengine.google.com/about/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
