sharmaar12 commented on code in PR #7464:
URL: https://github.com/apache/hbase/pull/7464#discussion_r2583706711
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -107,52 +123,136 @@ public void start(CoprocessorEnvironment env) throws
IOException {
public void stop(CoprocessorEnvironment env) {
}
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.UNITTEST)
+ public void setGlobalReadOnlyEnabled(boolean enabled) {
+ this.globalReadOnlyEnabled = enabled;
+ }
+
Review Comment:
But then we may need to create mini-cluster for it and then either set
read-only before cluster creation or notify the configuration observer. As I
have planned these tests to be small tests hence modifying the flag directly
made sense to me.
Also for the integration tests we are creating the a different JIRA to track
it which will cover this aspect.
What do you think?
@wchevreuil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
