wchevreuil commented on code in PR #7464:
URL: https://github.com/apache/hbase/pull/7464#discussion_r2588589541


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -107,52 +123,136 @@ public void start(CoprocessorEnvironment env) throws 
IOException {
   public void stop(CoprocessorEnvironment env) {
   }
 
+  @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.UNITTEST)
+  public void setGlobalReadOnlyEnabled(boolean enabled) {
+    this.globalReadOnlyEnabled = enabled;
+  }
+

Review Comment:
   >But then we may need to create mini-cluster for it and then either set 
read-only before cluster creation or notify the configuration observer.
   
   Nope, you don't need mini cluster. Just create a configuration and pass it 
to your controller instance as @anmolnar mentioned above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to