DieterDP-ng commented on code in PR #7582: URL: https://github.com/apache/hbase/pull/7582#discussion_r2677314263
########## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupOfflineRS.java: ########## Review Comment: We should also have a testcases for: - a RS goes offline after a full backup was taken, before an incremental is taken - a RS comes online & goes back offline before a full backup - a RS comes online & goes back offline after a full backup was taken, before an incremental backup At the same time, I realize the test code for each of these is quite elaborate. So I'm thinking it might be better to write a unit-type test for `IncrementalBackupManager` where the logs are abstracted away in an interface. Test code could then easily define which logs are present in a given scenario, and production code uses a file-based implementation of the logs. If you want, I could give a shot at refactoring the code for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
