hgromer commented on code in PR #7582:
URL: https://github.com/apache/hbase/pull/7582#discussion_r2682159689
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java:
##########
@@ -228,15 +263,6 @@ private List<String> getLogFilesForNewBackup(Map<String,
Long> olderTimestamps,
} else if (currentLogTS > oldTimeStamp) {
resultLogFiles.add(currentLogFile);
}
-
- // It is possible that a host in .oldlogs is an obsolete region server
Review Comment:
It depends
1. In isolation, without the other changes to this PR, it means we'll never
include the WAL files for a host that was removed for the cluster. Keep in
mind, currentLogFile is an oldLog. So backup happens, new wals get created and
moved to oldWAL dir, server goes offline, the boundary for that server is never
updated, those WAL files will never be included in future backups and we lose
data
2. In the context of this PR, we update the boundary for each host based on
the latest WAL that was included in the backup for the host, so this logic
actually completely irrelevant b/c newTimestamp will never be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
