[
https://issues.apache.org/jira/browse/HBASE-29843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053819#comment-18053819
]
Duo Zhang commented on HBASE-29843:
-----------------------------------
This is exactly what I want to avoid, that we call setPriority(int), and then
call setPriority(TableName), which is really really confusing...
What I want to provide is
1. A single place to setPriority in HBaseRpcController, where the value of
priority is based on the rules:
a. If the above layer set the priority directly, we use it.
b. Otherwise, we calculate the priority by TableName.
2. Users can override RpcControllerFactory, to have their own
HBaseRpcController implementation. In the implementation, you are free to just
ignore the setPriority(int) call, and calculate the priority with your own
algorithm.
Does this sound OK? Maybe we missed an important information that whether the
above layer has set the priority directly...
> HBaseRPCController.setPriority(final TableName tn) is never called on
> branch-3+
> -------------------------------------------------------------------------------
>
> Key: HBASE-29843
> URL: https://issues.apache.org/jira/browse/HBASE-29843
> Project: HBase
> Issue Type: Bug
> Components: rpc
> Affects Versions: 3.0.0-beta-1
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> HBaseRPCController makes it possible to set the priority based on the table
> name of an operation.
> This has stopped working on branch-3+.
> It is set at
> [https://github.com/apache/hbase/blob/8c69ba12f6daf853e4bd5ee78ab01a6f1a88eb89/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java#L122]
> on branch-2, but it is never called on branch-3 + .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
