[
https://issues.apache.org/jira/browse/HBASE-29843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053840#comment-18053840
]
Istvan Toth commented on HBASE-29843:
-------------------------------------
I looked into this a bit more:
The synchronous calls in 2.x. do this:
There is a priority we set when creating the call as a constructor/factory
parameter.
Then we use setPriority(int) to copy this into HBaseRPCController. (The
HBaseRPController can override the behaviour, HBaseRPControllerImpl only copies
if it's bigger than previously. )
Then - sometimes - we call setPriority(TableName) which in the case of
HBaseRPControllerImpl overrides the current priority uncoditionally.
The async call path mostly uses the ConnectionUtils to calculate the priority,
then uses setPriority(int) to set it on the controller.
I agree with your suggestion, as long as we remove the ConnectionUtils priority
code and update the Async RPC code to use HBaseRPControllerImpl instead.
> HBaseRPCController.setPriority(final TableName tn) is never called on
> branch-3+
> -------------------------------------------------------------------------------
>
> Key: HBASE-29843
> URL: https://issues.apache.org/jira/browse/HBASE-29843
> Project: HBase
> Issue Type: Bug
> Components: rpc
> Affects Versions: 3.0.0-beta-1
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> HBaseRPCController makes it possible to set the priority based on the table
> name of an operation.
> This has stopped working on branch-3+.
> It is set at
> [https://github.com/apache/hbase/blob/8c69ba12f6daf853e4bd5ee78ab01a6f1a88eb89/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java#L122]
> on branch-2, but it is never called on branch-3 + .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
