wchevreuil commented on code in PR #7617:
URL: https://github.com/apache/hbase/pull/7617#discussion_r2735996225
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##########
@@ -190,13 +204,16 @@ private void shipEdits(WALEntryBatch entryBatch) {
} else {
sleepMultiplier = Math.max(sleepMultiplier - 1, 0);
}
- // Clean up hfile references
- for (Entry entry : entries) {
- cleanUpHFileRefs(entry.getEdit());
- LOG.trace("shipped entry {}: ", entry);
+
+ stagedWalSize += currentSize;
+ entriesForCleanUpHFileRefs.addAll(entries);
+ lastShippedBatch = entryBatch;
+ if (shouldPersistLogPosition()) {
Review Comment:
> Are you referring to your original comment about passing the entire
entryBatch object?
No, I meant [this check
](https://github.com/apache/hbase/pull/7617/changes/8c828290cc7ab36b9db75a72916d6bbfd1dc4e47#diff-1907878c880a164eafc9eb5fb412a376d1d504bf54bfe91192e36693e60dfaf8L251)that
was being done inside "shouldPersistLogPosition", which would cause the buffer
size to be only considered for specific endpoint types.
@ankitsol has already addressed it on a recent commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
