ankitsol commented on code in PR #7617:
URL: https://github.com/apache/hbase/pull/7617#discussion_r2736370914
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##########
@@ -98,6 +103,14 @@ public final void run() {
LOG.info("Running ReplicationSourceShipper Thread for wal group: {}",
this.walGroupId);
// Loop until we close down
while (isActive()) {
+ // Whether to persist replication offsets based on size/time thresholds
+ if (shouldPersistLogPosition()) {
+ try {
+ persistLogPosition();
+ } catch (IOException e) {
+ LOG.warn("Exception while persisting replication state", e);
Review Comment:
persistLogPosition() throws Exception only from cleanUpHFileRefs() where
getBulkLoadDescriptor() can throw exception, hence I thought retry is not
necessary. I am thinking to keep this as it is, but move cleanUpHFileRefs()
towards the end of persistLogPosition() definition (after we update offset).
Please let me know your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
