ndimiduk commented on code in PR #7651: URL: https://github.com/apache/hbase/pull/7651#discussion_r2740907987
########## dev-support/test-waves/generate-wave-assignments.py: ########## @@ -0,0 +1,530 @@ +#!/usr/bin/env python3 +## +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +""" +Aggregate test runtimes from Jenkins nightlies and generate wave assignments for HBase CI. + +This script: +1. Downloads test_logs.zip from recent Jenkins nightly builds +2. Extracts and parses surefire XML files +3. Filters to Large tests only Review Comment: The Large test filtering is not exact because the reports do not include test category information. From my research, JUnit 5 will include `@Tag` information in the reports, so this system can become more reliable as we continue that migration. One alternative would be to search the source code and for each test found in the report and parse it for category information. Another, I think we could implement a custom surefire listener that inspects the Category annotation and writes that out to a file with the other surefire reports. Anyway, I think this approach is enough for now to get us started. Should if you think differently. ########## dev-support/test-waves/data/master/wave2-includes.txt: ########## @@ -0,0 +1,268 @@ +**/TestChoreService.java Review Comment: Will delete this file before merge. ########## .github/workflows/yetus-jdk17-hadoop3-unit-check.yml: ########## @@ -0,0 +1,124 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# yamllint disable rule:line-length +--- +name: Yetus JDK17 Hadoop3 Check + +"on": + pull_request: + types: [opened, synchronize, reopened] + +permissions: + contents: read + statuses: write + +jobs: + jdk17-hadoop3-check: + runs-on: ubuntu-latest + timeout-minutes: 360 + + strategy: Review Comment: I've separated the `unit` work from the other JDK+Hadoop checks. That other work is now in `yetus-jdkX-hadoopN-compile-check.yml`. The `unit` job now only includes the plugins that it requires to function. ########## dev-support/test-waves/data/master/wave3-includes.txt: ########## @@ -0,0 +1,268 @@ +**/TestClientOperationTimeout.java Review Comment: Will delete this file before merge. ########## dev-support/test-waves/data/master/wave1-excludes.txt: ########## @@ -0,0 +1,536 @@ +**/TestChoreService.java Review Comment: Will delete this file before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
