sidkhillon commented on code in PR #7741:
URL: https://github.com/apache/hbase/pull/7741#discussion_r2818222919
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/TagCompressionContext.java:
##########
@@ -127,6 +159,20 @@ public void uncompressTags(InputStream src, byte[] dest,
int offset, int length)
}
}
+ private byte[] getDeferredOrDictEntry(short dictIdx) {
+ if (deferAdditions) {
+ int deferredIdx = dictIdx - deferredBaseIndex;
Review Comment:
That's a good point. I have created an `UndoableLRUDictionary` that will let
us rollback changes to the dictionary, and I've added many scenarios to test it
out as unit tests. Please let me know how that looks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
