sidkhillon commented on code in PR #7741:
URL: https://github.com/apache/hbase/pull/7741#discussion_r2911939859
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/TagCompressionContext.java:
##########
@@ -38,20 +37,29 @@
*/
@InterfaceAudience.Private
public class TagCompressionContext {
- private final Dictionary tagDict;
+ private final UndoableLRUDictionary tagDict;
- public TagCompressionContext(Class<? extends Dictionary> dictType, int
dictCapacity)
- throws SecurityException, NoSuchMethodException, InstantiationException,
IllegalAccessException,
- InvocationTargetException {
- Constructor<? extends Dictionary> dictConstructor =
dictType.getConstructor();
- tagDict = dictConstructor.newInstance();
+ public TagCompressionContext(Class<? extends Dictionary> dictType, int
dictCapacity) {
Review Comment:
`dictType` is not really used beyond setting it to the default LRUDictionary
in the codebase, so to avoid confusion, I removed the argument from the
constructor and set the type explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
