charlesconnell commented on code in PR #7818:
URL: https://github.com/apache/hbase/pull/7818#discussion_r2873548467
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java:
##########
@@ -91,7 +92,7 @@ public class ReopenTableRegionsProcedure
/**
* Create a new ReopenTableRegionsProcedure respecting the throttling
configuration for the table.
* First check the table descriptor, then fall back to the global
configuration. Only used in
- * ModifyTableProcedure and in {@link HMaster#reopenRegionsThrottled}.
Review Comment:
Are you sure about this javadoc change? This looks wrong. I think to make
the link work property there need to be args, like `{@link
HMaster#reopenRegionsThrottled(TableName, ...}`
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java:
##########
@@ -94,11 +93,11 @@ protected void chore() {
tableToReopenRegionsMap.forEach((tableName, regionNames) -> {
try {
LOG.warn("Reopening regions due to high storeFileRefCount. "
- + "TableName: {} , noOfRegions: {}", tableName,
regionNames.size());
- hMaster.reopenRegions(tableName, regionNames,
NONCE_GENERATOR.getNonceGroup(),
Review Comment:
I can't really comment on whether it's a good idea to throttle these reopens
since I don't have enough context on this code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
