anmolnar commented on code in PR #7922:
URL: https://github.com/apache/hbase/pull/7922#discussion_r2927408814
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AbstractReadOnlyController.java:
##########
@@ -84,13 +85,14 @@ public static void manageActiveClusterIdFile(boolean
readOnlyEnabled, MasterFile
"Failed to delete active cluster file: {}. "
+ "Read-only flag will be updated, but file system state is
inconsistent.",
activeClusterFile, e);
+ } catch (DeserializationException e) {
+ LOG.error("Failed to deserialize ActiveClusterSuffix from file {}",
activeClusterFile, e);
Review Comment:
I'm not sure about catching the exception here. We just log the error and
proceed. Isn't that a problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
