anmolnar commented on code in PR #7922:
URL: https://github.com/apache/hbase/pull/7922#discussion_r2996362326


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AbstractReadOnlyController.java:
##########


Review Comment:
   I think you're right. Switching to non-readonly mode or in other words 
enabling write operation in the cluster is a risky operation and we should make 
sure that it's done properly and completely. If we're unable to write the lock 
file for some reason, we should deny the entire mode switch.
   
   On the other hand, we need to make progress and fixing such kind of things 
is not scope of this ticket, so I suggest to submit this first and open a new 
ticket to confirm and address the above mentioned problems.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to