Copilot commented on code in PR #8559:
URL: https://github.com/apache/hbase/pull/8559#discussion_r3836203507
##########
hbase-shaded/pom.xml:
##########
@@ -467,6 +467,9 @@
<exclude>jnamed*</exclude>
<exclude>lookup*</exclude>
<exclude>update*</exclude>
+ <!-- SPI provider ships only under META-INF/versions/18;
this jar is not
+ multi-release, so keeping the service file breaks
DNS on JDK18+ -->
+
<exclude>META-INF/services/java.net.spi.InetAddressResolverProvider</exclude>
Review Comment:
The PR description says the dnsjava filter should also drop the Java 18
multi-release entries (META-INF/versions/18/**), but the pom currently only
excludes the service declaration. If those versioned entries remain, the shaded
jar will still carry an unrelocated entry path that could resurface if the jar
ever becomes multi-release (and it also diverges from the stated fix). Consider
excluding the versioned directory as well, scoped to dnsjava only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
