junegunn commented on code in PR #8559:
URL: https://github.com/apache/hbase/pull/8559#discussion_r3836218231
##########
hbase-shaded/pom.xml:
##########
@@ -467,6 +467,9 @@
<exclude>jnamed*</exclude>
<exclude>lookup*</exclude>
<exclude>update*</exclude>
+ <!-- SPI provider ships only under META-INF/versions/18;
this jar is not
+ multi-release, so keeping the service file breaks
DNS on JDK18+ -->
+
<exclude>META-INF/services/java.net.spi.InetAddressResolverProvider</exclude>
Review Comment:
I did test the versioned exclusion and dropped it deliberately. Rebuilding
with only the service file excluded leaves
`META-INF/versions/18/org/xbill/DNS/spi/*` in place, and
`InetAddress.getByName` succeeds on Java 21, so the declaration is the only
thing that breaks DNS.
Updated the PR description to address the mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
