[
https://issues.apache.org/jira/browse/HBASE-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451126#comment-13451126
]
Ted Yu commented on HBASE-6730:
-------------------------------
{code}
+ private static final String KEEP_REGION_LOADS =
"hbase.master.balancer.stochastic.numRegionLoadsToRemember";
{code}
Line too long. The convention is that we don't need to capitalize letters in
config key.
{code}
+ //We're only going to keep 15. So if there are that many already
take the last 14
{code}
I think we should refer to numRegionLoadsToRemember instead of hardcoded values
(15 and 14)
{code}
+ for(RegionLoad rl:regionLoadList) {
{code}
nit: insert spaces in the above statement.
> Enable rolling averages in StochasticLoadBalancer
> --------------------------------------------------
>
> Key: HBASE-6730
> URL: https://issues.apache.org/jira/browse/HBASE-6730
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6730-1.patch, HBASE-6730-2.patch
>
>
> Now that all of the ServerLoad transitions into pb are done. the load
> balancer should get more updates about the current state of the cluster.
> This should be used to allow StochasticLoadBalancer to get rolling averages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
