d-c-manning opened a new pull request, #8730:
URL: https://github.com/apache/hbase/pull/8730

   [HBASE-30447](https://issues.apache.org/jira/browse/HBASE-30447)
   
   It is possible for table-level metrics from 
`MetricsTableWrapperAggregateImpl.java` to stop updating, and continually 
produce the last static value until RegionServer restart.
   
   The cause is not known but the most likely result is some type of 
`NullPointerException` in the `run` method.
   
   Because an exception is not caught in the `run` method, the 
`ScheduledFutureTask` will no longer be scheduled after the uncaught exception 
is thrown.
   
   There is no logging, so the cause of us seeing this behavior is not 
currently known. But with this issue fix, we could have logging to identify the 
source of the exception, which could lead to other bug fixes.
   
   We didn't have region-level metrics enabled at the time, but since 
`MetricsRegionWrapperImpl.java` has a similar pattern, I make a similar fix 
here.
   
   Due to the try-catch indentation, the fix is best visualized with ignoring 
whitespace.
   
   Relates to https://github.com/apache/hbase/pull/1729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to