Apache9 commented on code in PR #8577:
URL: https://github.com/apache/hbase/pull/8577#discussion_r4280211046
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionWithInMemoryFlush.java:
##########
@@ -58,20 +58,6 @@ protected HRegion initHRegion(TableName tableName, byte[]
startKey, byte[] stopK
isReadOnly, durability, wal, inMemory, families);
}
- @Override
- protected int getTestCountForTestWritesWhileScanning() {
Review Comment:
Why this method is removed here but not added in the two new classes?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java:
##########
@@ -254,6 +249,7 @@ public class TestHRegion {
protected final MetricsAssertHelper metricsAssertHelper =
CompatibilitySingletonFactory.getInstance(MetricsAssertHelper.class);
+
Review Comment:
Why an empty newline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
