Sigma-Ma opened a new pull request, #8802: URL: https://github.com/apache/hbase/pull/8802
### What changes were proposed in this pull request? Run TestShadedTestingUtilJarContents in shadedjars after packaging, alongside the existing invariant checks. Also trigger shadedjars when the personality or JAR validation scripts change. ### Why are the changes needed? After #8789, clean test skips the JAR contents check when HBaseTestingUtil is loaded from a class directory. Nightly builds still need to check the packaged testing util for bundled JUnit libraries. ### How was this patch tested? Tested locally with JDK 17.0.20.1 and Maven 3.6.3. ```bash mvn -B -ntp -pl hbase-shaded/hbase-shaded-testing-util-tester -am -Dtest=TestShadedTestingUtilJarContents,TestShadedHBaseTestingUtility -Dsurefire.firstPartGroups=org.apache.hadoop.hbase.testclassification.SmallTests,org.apache.hadoop.hbase.testclassification.MediumTests -Dsurefire.skipSecondPart=true -Dsurefire.rerunFailingTestsCount=0 clean test mvn -ntp clean verify -fae --batch-mode -pl hbase-shaded/hbase-shaded-check-invariants,hbase-shaded/hbase-shaded-testing-util-tester -am -DskipTests=false -Dtest=TestShadedTestingUtilJarContents -DHBasePatchProcess -Prelease -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true mvn -B -ntp -pl hbase-shaded/hbase-shaded-testing-util-tester -am -DskipTests=false -Dtest=TestShadedTestingUtilJarContents -Dsurefire.rerunFailingTestsCount=0 verify mvn -N -B -ntp spotless:check bash -n dev-support/hbase-personality.sh ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
