charlesconnell commented on code in PR #8802:
URL: https://github.com/apache/hbase/pull/8802#discussion_r4636094564
##########
dev-support/hbase-personality.sh:
##########
@@ -549,8 +551,8 @@ function shadedjars_rebuild
start_clock
local -a maven_args=('clean' 'verify' '-fae' '--batch-mode'
- '-pl' 'hbase-shaded/hbase-shaded-check-invariants' '-am'
- '-DskipTests' '-DHBasePatchProcess' '-Prelease'
+ '-pl'
'hbase-shaded/hbase-shaded-check-invariants,hbase-shaded/hbase-shaded-testing-util-tester'
'-am'
+ '-DskipTests=false' '-Dtest=TestShadedTestingUtilJarContents'
'-DHBasePatchProcess' '-Prelease'
Review Comment:
Could you remove the `skipTests` argument entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]