hgromer commented on code in PR #8821:
URL: https://github.com/apache/hbase/pull/8821#discussion_r4405210182
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotProcedure.java:
##########
@@ -263,6 +263,19 @@ protected synchronized boolean
setTimeoutFailure(MasterProcedureEnv env) {
return false;
}
+ @Override
+ protected void completionCleanup(MasterProcedureEnv env) {
Review Comment:
From how I've traced it, I think it should. Here's the path I followed
1. bypass get's called, procedures bypass flag gets set to true b/c it uses
the parent behavior
2. on the next run of doExecute, we return null because the procedure was
bypassed
3. because we've returned null (subprocs == null), and we are not in a
WAITING_TIMEOUT state, we set the procedure state to ProcedureState.SUCCESS
4. this then follows the normal procedure succeeded code path, which
eventually calls out to proc.completionCleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
