hgromer commented on code in PR #8821:
URL: https://github.com/apache/hbase/pull/8821#discussion_r4407583046
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotProcedure.java:
##########
@@ -263,6 +263,19 @@ protected synchronized boolean
setTimeoutFailure(MasterProcedureEnv env) {
return false;
}
+ @Override
+ protected void completionCleanup(MasterProcedureEnv env) {
Review Comment:
Good question, the happy path is a bit different. On snapshot completion,
the files under the `.hbase-snapshot/.tmp` dir get moved over to
`.hbase-snapshot/`.
Those files will stay there until either
1. Someone cleans them up explicitly, typically after an ExportSnapshot
2. The snapshot is TTLd, via the `SnapshotCleanerChore`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
