Copilot commented on code in PR #8825:
URL: https://github.com/apache/hbase/pull/8825#discussion_r4418436340
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncScanSingleRegionRpcRetryingCaller.java:
##########
@@ -521,7 +521,7 @@ private void onComplete(HBaseRpcController controller,
ScanResponse resp) {
int numberOfCompleteRowsBefore = resultCache.numberOfCompleteRows();
try {
rawResults = ResponseConverter.getResults(controller.cellScanner(),
resp);
- updateResultsMetrics(scanMetrics, rawResults, isHeartbeatMessage);
+ updateResultsMetrics(scanMetrics, rawResults, regionServerRemote);
Review Comment:
This call changes the meaning of the third argument from \"heartbeat
response\" to \"region server is remote\". To avoid future confusion/bugs,
please ensure `updateResultsMetrics`’s signature/parameter name (and any
related comments) reflect the new semantics (e.g., rename the parameter to
`regionServerRemote`/`isRemoteRegionServer`). If `updateResultsMetrics` still
needs heartbeat context for other counters, consider passing both booleans or
splitting the logic so remote-bytes accounting is clearly separated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
